Properly set values in subforms#10
Merged
kitlangton merged 2 commits intokitlangton:masterfrom Jan 22, 2023
Merged
Conversation
Owner
|
I'll take it! Perhaps the experts on the laminar gitter might have some ways of getting around the manual owner, but this seems great for now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of relying on
setTimeoutwhich can be flaky for obvious reasons, we now spawn a listener on the updatingSignalto set the new value on the subform.The downside here is that an
Ownermust be spawned each time we do this (I'm not sure about the overhead?) but we can can also kill again it each time it's done; hopefully this is enough to prevent leaks.