Add Model format field to Kitfile#645
Merged
amisevsk merged 1 commit intokitops-ml:mainfrom Dec 11, 2024
Merged
Conversation
To make runtime usage simpler, add Kitfile field .model.format. This can be set to store the model's data format (e.g. safetensors, gguf, onnx, etc.). This information can be used by runtimes to determine how to consume the model (e.g. if the runtime can handle .gguf files)
Member
|
Do we also need to record the |
Contributor
Author
|
Maybe, but adding that is a backwards-compatible change we can make if we decide we need it. I'd rather not throw fields into the spec unless we know they're going to be used somewhere. |
Member
|
the reason I brought this up on the annotations that we had proposed on model specification group, I had it listed as |
gorkem
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To make runtime usage simpler, add Kitfile field .model.format. This can be set to store the model's data format (e.g. safetensors, gguf, onnx, etc.).
This information can be used by runtimes to determine how to consume the model (e.g. if the runtime can handle .gguf files)
Linked issues
No issue at the moment