Skip to content

Allow specifying a separate target reference to push in kit push#685

Merged
amisevsk merged 2 commits intokitops-ml:mainfrom
amisevsk:push-target
Jan 13, 2025
Merged

Allow specifying a separate target reference to push in kit push#685
amisevsk merged 2 commits intokitops-ml:mainfrom
amisevsk:push-target

Conversation

@amisevsk
Copy link
Copy Markdown
Contributor

Description

Allow specifying a separate push target, so that you don't have to tag ModelKits locally before pushing (similar to what podman--but not docker--does).

  • Push locally-tagged image to remote (same as what we currently do):
    kit push registry.example.com/myorg/mymodel:mytag
    
  • Push a local image to the same remote without tagging first
    kit push localmodel:latest registry.example.com/myorg/mymodel:mytag
    

Linked issues

I didn't create an issue for this one yet, but I figured it'd be useful while working on #684, which by default tags according to the HF repo

Add a two-argument version of `kit push` that allows pushing local
modelkits without explicitly tagging them first.

When specified with one argument, e.g.

  kit push example.com/myorg/myrepo:mytag

we'll push the locally-tagged ModelKit as before. When specified with
two arguments, e.g.

  kit push myorg/mymodel:mytag example.com/neworg/newrepo:newtag

we'll push the locally tagged model to the remote registry under a
differente repository
@amisevsk amisevsk requested a review from gorkem January 10, 2025 18:32
Comment thread pkg/cmd/push/cmd.go
Comment thread pkg/cmd/push/cmd.go
Comment thread pkg/cmd/push/cmd.go
@amisevsk amisevsk merged commit a2b1a09 into kitops-ml:main Jan 13, 2025
@amisevsk amisevsk deleted the push-target branch January 13, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants