Add tests for generating Kitfiles.#693
Merged
amisevsk merged 3 commits intokitops-ml:mainfrom Jan 16, 2025
Merged
Conversation
gorkem
approved these changes
Jan 16, 2025
| t.Run(fmt.Sprintf("%s (%s)", tt.Name, tt.Description), func(t *testing.T) { | ||
| // Set up temporary directory for work | ||
| tmpDir, removeTmp := setupTempDir(t) | ||
| defer removeTmp() |
Member
There was a problem hiding this comment.
I wonder if t.Cleanup() works better.
Contributor
Author
There was a problem hiding this comment.
It certainly does, and this is me learning about its existence :)
Contributor
Author
There was a problem hiding this comment.
Updated all our tests to use cleanup, much cleaner
To ensure generated Kitfiles are consistent, generate Kitfiles that
always use the forward slash ('/') as a path separator. This means
replacing slashes in windows-style paths with forward-slashes.
amisevsk
force-pushed
the
kitfile-generation-tests
branch
from
5db3eab to
e998dc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add test cases for generating Kitfiles. Should probably also include a test for license detection but it's harder to fit into the framework we've got.
Linked issues
Related: #124, #564