Skip to content

Add 'diff' command to compare ModelKits#702

Merged
gorkem merged 5 commits intokitops-ml:mainfrom
gorkem:diff-command
Feb 3, 2025
Merged

Add 'diff' command to compare ModelKits#702
gorkem merged 5 commits intokitops-ml:mainfrom
gorkem:diff-command

Conversation

@gorkem
Copy link
Copy Markdown
Member

@gorkem gorkem commented Jan 20, 2025

Enable comparison of local and remote ModelKits, displaying shared and unique layers

Copy link
Copy Markdown
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments

Comment thread pkg/cmd/diff/cmd.go Outdated
Comment thread pkg/cmd/diff/cmd.go
Comment thread pkg/cmd/diff/cmd.go
Comment thread pkg/cmd/diff/cmd.go Outdated
Comment thread pkg/cmd/diff/diff.go
Comment thread pkg/cmd/diff/diff.go
Enable comparison of local and remote ModelKits,
displaying shared and unique layers
Adds sorting, fixes the import alias to be consistet
with the rest of the codebase.
Compares if the annotations match
Comment thread pkg/cmd/diff/cmd.go Outdated
Comment thread pkg/cmd/diff/cmd.go Outdated
Comment thread pkg/cmd/diff/cmd.go Outdated
Comment thread pkg/cmd/diff/cmd.go Outdated
- fixes formatting missing examples, moves the doc
strings to const.
- removes uncessary arg checks
Copy link
Copy Markdown
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gorkem gorkem merged commit ccea97b into kitops-ml:main Feb 3, 2025
@gorkem gorkem deleted the diff-command branch February 3, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants