Auto-fill name/author when using kit import#722
Merged
amisevsk merged 2 commits intokitops-ml:mainfrom Jan 24, 2025
Merged
Conversation
gorkem
approved these changes
Jan 24, 2025
Member
|
Test failure on this one |
To avoid empty values appearing in 'kit list', set name and author from the passed in repository -- name is the last segment of the URL, author is the second last. This turns e.g. https://github.com/jozu-ai/kitops into the following package package: name: kitops authors: [jozu-ai] An alternative would be to prompt the user (and provide optional flags) but this a) complicates the command, and b) duplicates the 'edit Kitfile' functionality in the later step.
amisevsk
force-pushed
the
import-flags
branch
from
38c9781 to
7692450
Compare
Contributor
Author
|
The test failure was because I wasn't handling the author field correctly (it would add an empty author to the Kitfile rather than omitting the field entirely). Fixed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
kit import(name is repo name, author is organization)Linked issues
Closes #717