Ensure we don't store duplicate manifests in the index#729
Merged
amisevsk merged 2 commits intokitops-ml:mainfrom Jan 28, 2025
Merged
Ensure we don't store duplicate manifests in the index#729amisevsk merged 2 commits intokitops-ml:mainfrom
amisevsk merged 2 commits intokitops-ml:mainfrom
Conversation
Avoid accidentally adding the same manifest multiple times to the local storage index. Previously, the addManifest method would not check if the manifest was already saved, leading to duplicated entries.
Since indexes may contain duplicate entries due to a bug, de-duplicate them when saving to 'fix' indexes that have the issue.
gorkem
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid accidentally adding the same manifest multiple times to the local storage index. Previously, the addManifest method would not check if the manifest was already saved, leading to duplicated entries.
Reproducer
kit pullthe same ModelKit multiple times (previously, would result in multiple identical lines inkit list)Linked issues
closes #730