Use monolithic uploads when pushing to Google Artifact Registry#780
Merged
amisevsk merged 2 commits intokitops-ml:mainfrom Feb 25, 2025
Merged
Conversation
Google Artifact Registry does not support chunked uploads and instead requires monolithic uploads. Handle pushes to the registry similar to how we handle ghcr.io (matching .pkg.dev)
Member
|
Do we have tests covering upload-format? The list of special treatments may be growing. |
Contributor
Author
Good idea, I'll add some |
amisevsk
force-pushed
the
google-artifact-registry-support
branch
from
75dcb76 to
5d1af89
Compare
Contributor
Author
|
Tested on Google Artifact Registry and was able to push a 1GB layer without issue. I logged in using an access_token, as Kit currently does not support auth helpers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Google Artifact Registry does not support chunked uploads and instead requires monolithic uploads. Handle pushes to the registry similar to how we handle ghcr.io (matching .pkg.dev)
Note: I haven't been able to test this directly, yet, as I don't have access to a Google Artifact Registry at the moment. I'll test to double check before merging
Linked issues
Closes #777