Add authentication for KServer ClusterStorageContaier#827
Merged
gorkem merged 2 commits intokitops-ml:mainfrom Apr 18, 2025
Merged
Add authentication for KServer ClusterStorageContaier#827gorkem merged 2 commits intokitops-ml:mainfrom
gorkem merged 2 commits intokitops-ml:mainfrom
Conversation
Updates the entrypoint do that it performs a kit login if KIT_USER and KIT_PASSWORD are set or AWS IRSA is enabled. Signed-off-by: Gorkem Ercan <gorkem.ercan@gmail.com>
gorkem
force-pushed
the
kserve-auth
branch
2 times, most recently
from
654fc56 to
9f3af7e
Compare
amisevsk
reviewed
Apr 17, 2025
Comment on lines
+59
to
+64
| ```bash | ||
| # Example: build against Kit v1.3.0 instead of "next" | ||
| docker build \ | ||
| -t kitops-kserve:latest \ | ||
| --build-arg KIT_BASE_IMAGE=ghcr.io/kitops-ml/kitops:v1.3.0 \ | ||
| . |
Contributor
There was a problem hiding this comment.
Missing a closing ``` on this code block
Comment on lines
-9
to
-10
| read -r AWS_ECR_REGION <<< "$AWS_ECR_REGION" | ||
| read -r AWS_ROLE_ARN <<< "$AWS_ROLE_ARN" |
Contributor
There was a problem hiding this comment.
I think these changes were dropped in the rebase -- the AWS IRSA handling is still useful outside the more general login use case.
Member
Author
There was a problem hiding this comment.
I intentionally removed it was redundant
Contributor
There was a problem hiding this comment.
Ah I missed the change below, sorry
Adds unit tests for the entrypoint.sh Updates README.md Signed-off-by: Gorkem Ercan <gorkem.ercan@gmail.com>
amisevsk
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the entrypoint.sh do that it performs a kit login if KIT_USER and KIT_PASSWORD are set or AWS IRSA is enabled.