Why not using the latest tag as default ? #935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mohammed <mohammed18200118@gmail.com>
Signed-off-by: mohammed <mohammed18200118@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR improves the default behavior when no tag is specified in image references by defaulting to the "latest" tag instead of an empty string. This addresses a user experience issue where pushing images without specifying a tag resulted in unclear error messages.
- Updates the reference parsing logic to default to "latest" tag when no tag is provided
- Updates corresponding test cases to reflect the new default behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/lib/repo/util/reference.go | Adds default "latest" tag assignment when no tag or digest is specified |
| pkg/lib/repo/util/reference_test.go | Updates test expectations to use "latest" tag for references without explicit tags |
amisevsk
approved these changes
Aug 7, 2025
Contributor
amisevsk
left a comment
amisevsk
left a comment
There was a problem hiding this comment.
I think this is a good idea, considering how many users I've seen run into the same issue.
2 tasks
amisevsk
added a commit
that referenced
this pull request
Nov 4, 2025
This reverts commit e0d4ced. Signed-off-by: Angel Misevski <amisevsk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried pushing an image, and I didn't specify the tag and I got that error (which wasn't clear to me)
[ERROR] Failed to push: failed to copy to remote: failed to perform "Resolve" on source: missing reference.maybe it's a skill issue for me, but I didn't know reference means tag here until I looked inside the code