fix: don't exit process on stderr output#133
Merged
kitplummer merged 1 commit intodevelopfrom Jan 10, 2026
Merged
Conversation
Fixes #132 The execute_command function was calling process::exit() whenever a command wrote anything to stderr, even on successful execution. Many tools (cargo, npm, etc.) write progress info to stderr. Changed behavior: - Print stderr output but continue execution - Only return error if exit code is non-zero - Applies to both timeout and non-timeout code paths This allows goa to continue watching after CI commands complete. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #132
The
execute_commandfunction was callingprocess::exit()whenever a command wrote anything to stderr, even on successful execution. Many tools (cargo, npm, git, etc.) write progress info to stderr, causing goa to exit prematurely.Changes
Impact
This bug affected both
spyandradiclesubcommands, but was more visible with Radicle since CI commands typically produce stderr output.Test plan
🤖 Generated with Claude Code