Skip to content

Conversation

@alexec
Copy link
Contributor

@alexec alexec commented Nov 22, 2025

Implements ParseParams function that correctly parses key=value pairs from a string with proper quote handling.

Features

  • Requires all values to be double-quoted
  • Handles escaped quotes within quoted values
  • Handles empty quoted values
  • Proper whitespace handling
  • Parses multiple pairs in a single string
  • Returns error for unquoted values or unclosed quotes

API Changes

  • Function signature changed to return (Params, error) to support error handling
  • Unquoted values are treated as an error

Testing

All tests pass including comprehensive test coverage for various quote scenarios and error cases.

Implement ParseParams function that correctly parses key=value pairs
with support for:
- Double and single quoted values
- Escaped quotes within quoted values
- Empty values
- Whitespace handling
- Multiple pairs in a single string
Only double-quotes are now supported for quoted values.
Single quotes are treated as regular characters in unquoted values.
ParseParams now requires all values to be double-quoted.
Unquoted values are treated as an error. Function signature
changed to return (Params, error) to support error handling.
@alexec alexec marked this pull request as ready for review November 22, 2025 19:30
@alexec alexec enabled auto-merge (squash) November 22, 2025 19:30
@alexec alexec merged commit ef8d40f into main Nov 22, 2025
1 check passed
@alexec alexec deleted the feat/parse-params-quotes branch November 22, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants