Add named parameter support to slash commands #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended slash command parsing to support named parameters in key="value" format
alongside existing positional parameters. Named parameters can be mixed with
positional arguments and do not count toward positional numbering.
Examples:
- /fix-bug issue="PROJ-123" -> ${issue} = "PROJ-123"
- /task arg1 key="value" arg2 -> ${1}="arg1", ${2}="arg2", ${key}="value"
Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for named parameters in slash commands
Add named parameter support to slash commands
Dec 2, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds named parameter support to slash commands, allowing users to specify parameters using key="value" syntax in addition to existing positional parameters. The implementation extends the argument parsing logic to detect and extract named parameters while maintaining backward compatibility with positional arguments.
Key Changes
- Added
parseBashArgsWithNamedfunction to parse both positional and named parameters from argument strings - Added
parseNamedParamhelper to identify arguments inkey=valueformat - Extended test coverage with 8 new test cases covering various named parameter scenarios
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
pkg/codingcontext/slashcommand.go |
Implemented named parameter parsing logic with parseBashArgsWithNamed and parseNamedParam functions; updated documentation comments to describe new syntax |
pkg/codingcontext/slashcommand_test.go |
Added comprehensive test cases for named parameters including spaces in values, escaped quotes, mixed usage with positional args, and special characters |
docs/reference/cli.md |
Documented named parameter syntax with examples showing usage patterns and equivalents to manual -p flag usage |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Contributor
|
@copilot positional arguments should retain their numbering: lts in:
|
Contributor
|
@copilot make quotes mandatory. You can extract the same parser we used for |
Updated slash command parsing so that named parameters (key="value") are also
included as positional arguments in their original form. This addresses the
feedback that `/task arg1 issue="PROJ-123" arg2` should result in:
- ${1} = arg1
- ${2} = issue="PROJ-123"
- ${3} = arg2
- ${issue} = PROJ-123
Also added protections:
- Reserved key ARGUMENTS cannot be used as a named parameter key
- Numeric keys (1, 2, etc.) cannot be used as named parameter keys
- Duplicate named parameter keys: last value wins (documented behavior)
Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
Contributor
Author
... Fixed in ee87d79. Named parameters now count toward positional numbering.
Also added protections for reserved keys (ARGUMENTS, numeric keys). |
Per @alexec's feedback, named parameters now require mandatory double quotes. - Unquoted values like `key=value` are treated as positional arguments - Single-quoted values like `key='value'` are also treated as positional arguments - Only `key="value"` format is recognized as a named parameter Updated parseNamedParamWithQuotes to validate double quote requirement. Added tests for unquoted and single-quoted edge cases. Updated documentation to clarify mandatory double quotes. Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
Contributor
Author
alexec
reviewed
Dec 2, 2025
alexec
reviewed
Dec 2, 2025
Replaced manual character-by-character numeric check with strconv.Atoi for cleaner, more idiomatic Go code. Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
Changed return type from ([]string, map[string]string, error) to
(map[string]string, error). The map now contains both positional keys
("1", "2", "3", etc.) and named parameter keys, eliminating the need
for a separate allArgs slice.
Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
Contributor
|
@copilot don't worry about protecting numeric arguments or ARGUMENTS. A user would have to misuse the system greatly for this to happen. |
Per @alexec's feedback, removed the validation that prevented named parameters from using ARGUMENTS or numeric keys. Users would have to misuse the system greatly for this to cause problems. Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
Contributor
Author
alexec
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.