Skip duplicate memory files by name #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Track memory names from frontmatter and exclude subsequent files that share the same name. Print a message when a file is skipped.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements memory deduplication based on frontmatter name attributes to prevent duplicate memories from being included in the generated context. When multiple memory files have the same name in their frontmatter, only the first one encountered is included.
- Adds name-based deduplication logic to track and exclude memories with duplicate names
- Includes a test to verify that only one memory file is included when multiple files share the same name
- Documents the new deduplication feature with examples and naming conventions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| main.go | Implements deduplication by tracking memory names in a map and excluding subsequent files with the same name |
| memory_name_test.go | Adds test coverage for the memory name deduplication feature |
| README.md | Documents the new deduplication feature with examples and naming conventions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@copilot we don't need to de-dupe based on "name:". Instead use the basename of the memory file. |
Contributor
#45) * Initial plan * Change deduplication from frontmatter name to basename Co-authored-by: alexec <1142830+alexec@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track memory names from frontmatter and exclude subsequent files that share the same name. Print a message when a file is skipped.