feat: sync agent directories by alexec · Pull Request #54 · kitproj/coding-context-cli

alexec · 2025-11-02T22:40:30Z

No description provided.

Copilot

Pull Request Overview

This PR refactors the coding-context tool to simplify its architecture by changing from a multi-file output approach (persona.md, rules.md, task.md) to a single stdout-based output. The command-line interface now requires both an agent name and task name as arguments, and the tool generates agent-specific rule mappings.

Removed embedded bootstrap script and persona/task file generation
Changed CLI from [task-name] [persona-name] to <agent-name> <task-name> (both now required)
Introduced agent-specific rule path mappings for various AI coding assistants (ClaudeCode, Cursor, Windsurf, etc.)

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 11 comments.

File	Description
main.go	Complete refactoring of the main logic: removed persona/task file generation, added agent-specific rule path lookups, changed output from files to stdout, and modified argument validation to require exactly 2 arguments
bootstrap	Removed the embedded bootstrap script file entirely

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-02T22:42:51Z

main.go

-				return fmt.Errorf("failed to stat persona path %s: %w", path, err)
+	for source, target := range map[string]string{
+
+		// --- USER RULES (GLOBAL PERSUASION, HOME DIRECTORY) ---


Corrected spelling of 'PERSUASION' to 'PERSONA'. The comment appears to be describing user-level persona configuration.

Suggested change

// --- USER RULES (GLOBAL PERSUASION, HOME DIRECTORY) ---

// --- USER RULES (GLOBAL PERSONA, HOME DIRECTORY) ---

Copilot · 2025-11-02T22:42:51Z

main.go

+		// --- USER RULES (GLOBAL PERSUASION, HOME DIRECTORY) ---
+		// These files define the agent's persona and rules across all projects.
+		// Standardized value format: ~/.agents/rules/<purpose>.md
+		homeDir + "/.claude/CLAUDE.md": homeDir + ".agents/rules/CLAUDE.md",  // Claude Code global persona [1]


Missing path separator in the target path. Should be homeDir + \"/.agents/rules/CLAUDE.md\" to avoid creating a malformed path like /home/user.agents/rules/CLAUDE.md.

Suggested change

homeDir + "/.claude/CLAUDE.md": homeDir + ".agents/rules/CLAUDE.md", // Claude Code global persona [1]

homeDir + "/.claude/CLAUDE.md": homeDir + "/.agents/rules/CLAUDE.md", // Claude Code global persona [1]

Copilot · 2025-11-02T22:42:51Z

main.go

+		// Standardized value format: ~/.agents/rules/<purpose>.md
+		homeDir + "/.claude/CLAUDE.md": homeDir + ".agents/rules/CLAUDE.md",  // Claude Code global persona [1]
+		homeDir + "/.gemini/GEMINI.md": homeDir + "/.agents/rules/GEMINI.md", // Gemini CLI global context [2]
+		homeDir + "/.codex/AGENTS.md":  homeDir + ".agents/rules/CODEX.md",   // Codex CLI global guidance [3]


Missing path separator in the target path. Should be homeDir + \"/.agents/rules/CODEX.md\" to avoid creating a malformed path like /home/user.agents/rules/CODEX.md.

Suggested change

homeDir + "/.codex/AGENTS.md": homeDir + ".agents/rules/CODEX.md", // Codex CLI global guidance [3]

homeDir + "/.codex/AGENTS.md": homeDir + "/.agents/rules/CODEX.md", // Codex CLI global guidance [3]

Copilot · 2025-11-02T22:42:52Z

main.go

+		homeDir + "/.gemini/GEMINI.md": homeDir + "/.agents/rules/GEMINI.md", // Gemini CLI global context [2]
+		homeDir + "/.codex/AGENTS.md":  homeDir + ".agents/rules/CODEX.md",   // Codex CLI global guidance [3]
+
+		// --- PROJECT RULES (ANCSTOR & PWD-SPECIFIC GUIDANCE) ---


Corrected spelling of 'ANCSTOR' to 'ANCESTOR'.

Suggested change

// --- PROJECT RULES (ANCSTOR & PWD-SPECIFIC GUIDANCE) ---

// --- PROJECT RULES (ANCESTOR & PWD-SPECIFIC GUIDANCE) ---

Copilot · 2025-11-02T22:42:52Z

main.go

+			// Check for a bootstrap file named <markdown-file-without-md/mdc-suffix>-bootstrap
+			// For example, setup.md -> setup-bootstrap, setup.mdc -> setup-bootstrap
+			baseNameWithoutExt := strings.TrimSuffix(path, ext)
+			bootstrapSoucePath := baseNameWithoutExt + "-bootstrap"


Corrected spelling of 'bootstrapSoucePath' to 'bootstrapSourcePath'.

Copilot · 2025-11-02T22:42:53Z

main.go

+		if os.IsExist(err) {
 			continue
+		} else if err != nil {


Logic error: os.IsExist(err) returns true when a path already exists (when creating), but this is checking the error from os.RemoveAll. Should use os.IsNotExist(err) to skip if the file doesn't exist, or remove this check entirely since os.RemoveAll doesn't error if the path doesn't exist.

Suggested change

if os.IsExist(err) {

continue

} else if err != nil {

if err != nil {

Copilot · 2025-11-02T22:42:53Z

main.go

+	for _, rulePath := range []string{
+		".agents/rules",
+		filepath.Join(userConfigDir, "agents", "rules"),
+		"/etc/agents/tasks",


Wrong path in rules iteration. This array is iterating over rule paths but includes /etc/agents/tasks which should be /etc/agents/rules to match the pattern established in the agentRulesPathLookup map.

Suggested change

"/etc/agents/tasks",

"/etc/agents/rules",

Copilot · 2025-11-02T22:42:53Z

main.go


-			// Only process .md and .mdc files as rule files
+			// Only process .md files as rule files
 			ext := filepath.Ext(path)
-			if ext != ".md" && ext != ".mdc" {
+			if ext != ".md" {
 				return nil
 			}


Missing directory check. Unlike the first loop (lines 117-119), this code doesn't skip directories before checking file extensions, which could cause issues if filepath.Walk encounters a directory with no extension.

Copilot · 2025-11-02T22:42:53Z

main.go

-				if err := os.WriteFile(bootstrapPath, bootstrapContent, 0700); err != nil {
-					return fmt.Errorf("failed to write bootstrap file: %w", err)
-				}
+			bootstrapSoucePath := baseNameWithoutExt + "-bootstrap"


Corrected spelling of 'bootstrapSoucePath' to 'bootstrapSourcePath'.

Copilot · 2025-11-02T22:42:53Z

main.go

+	} {

-		err := filepath.Walk(rule, func(path string, info os.FileInfo, err error) error {
+		err = filepath.Walk(rulePath, func(path string, info os.FileInfo, err error) error {


This definition of err is never used.

alexec · 2025-11-02T22:44:44Z

@copilot Think deeply about this change. Write a test suite.

Copilot · 2025-11-02T22:44:51Z

@alexec I've opened a new pull request, #55, to work on those changes. Once the pull request is ready, I'll request review from you.

feat: sync agent directories

d72a666

alexec requested a review from Copilot November 2, 2025 22:40

Copilot AI reviewed Nov 2, 2025

View reviewed changes

Copilot AI mentioned this pull request Nov 2, 2025

Add comprehensive test suite and fix directory creation bugs #55

Closed

alexec closed this Nov 3, 2025

	// --- USER RULES (GLOBAL PERSUASION, HOME DIRECTORY) ---
	// --- USER RULES (GLOBAL PERSONA, HOME DIRECTORY) ---

	homeDir + "/.claude/CLAUDE.md": homeDir + ".agents/rules/CLAUDE.md", // Claude Code global persona [1]
	homeDir + "/.claude/CLAUDE.md": homeDir + "/.agents/rules/CLAUDE.md", // Claude Code global persona [1]

	homeDir + "/.codex/AGENTS.md": homeDir + ".agents/rules/CODEX.md", // Codex CLI global guidance [3]
	homeDir + "/.codex/AGENTS.md": homeDir + "/.agents/rules/CODEX.md", // Codex CLI global guidance [3]

	// --- PROJECT RULES (ANCSTOR & PWD-SPECIFIC GUIDANCE) ---
	// --- PROJECT RULES (ANCESTOR & PWD-SPECIFIC GUIDANCE) ---

Conversation

alexec commented Nov 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

alexec commented Nov 2, 2025

Uh oh!

Copilot AI commented Nov 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants