Remove unused task metrics feature#126
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Remove unused task metrics feature from the repository
Remove unused task metrics feature
Jun 26, 2026
Collaborator
|
@copilot fix conflicts. |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the previously implemented (but unused) task memory metrics pipeline end-to-end, including backend collection/parsing, propagation through TaskNode, and Web UI rendering, and updates documentation to match.
Changes:
- Removed
types.Metrics, theinternal/metricsparsing helpers, andGetMetricsfrom theproc.Interfaceplus all implementations. - Removed the periodic metrics polling goroutine and eliminated the
TaskNode.Metricsfield. - Removed all metrics-related UI bindings/CSS/formatting and updated README to no longer claim “real-time metrics”.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates Web UI feature description to remove “real-time metrics” claim. |
| internal/types/metrics.go | Deletes the Metrics struct type. |
| internal/task_node.go | Removes TaskNode.Metrics JSON field. |
| internal/run.go | Removes the 20s polling goroutine that collected/published metrics. |
| internal/proc/proc.go | Removes GetMetrics from the proc.Interface. |
| internal/proc/noop.go | Removes the noop metrics implementation and related import. |
| internal/proc/kubernetes.go | Removes Kubernetes metrics aggregation/helpers and related imports/comments. |
| internal/proc/host.go | Removes host ps-based metrics collection and related import. |
| internal/proc/container.go | Removes container procfs metrics collection and related import. |
| internal/metrics/ps.go | Deletes ps parsing helpers. |
| internal/metrics/procfs.go | Deletes procfs parsing helpers. |
| internal/index.html | Removes metrics DOM element, CSS, formatter, and data bindings in initial render + SSE updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metrics collection feature (memory usage via
ps/procfs) was fully wired up but never consumed by anything meaningful. Removes the entire code path end-to-end.Removed
internal/types/metrics.go—Metricsstructinternal/metrics/package —psandprocfsmemory parsing helpersGetMetrics(ctx) (*types.Metrics, error)fromproc.Interfaceand all implementations (host,container,k8s,noop), including k8s private helpers (getMetrics,getContainersInPod,getContainerMetrics)internal/run.gothat calledp.GetMetricsand stuffed results ontonode.MetricsMetricsfield fromTaskNodeUI (
internal/index.html)#metricsCSS rule,<span id="metrics">DOM element,formatMetrics()JS function, and allnode.metricsdata bindings in both the initial graph render and SSE update pathsDocs
README.md