Skip to content

Remove unused task metrics feature#126

Merged
alexec merged 3 commits into
mainfrom
copilot/remove-unused-task-metrics-feature
Jun 26, 2026
Merged

Remove unused task metrics feature#126
alexec merged 3 commits into
mainfrom
copilot/remove-unused-task-metrics-feature

Conversation

Copilot AI commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

The metrics collection feature (memory usage via ps/procfs) was fully wired up but never consumed by anything meaningful. Removes the entire code path end-to-end.

Removed

  • internal/types/metrics.goMetrics struct
  • internal/metrics/ package — ps and procfs memory parsing helpers
  • GetMetrics(ctx) (*types.Metrics, error) from proc.Interface and all implementations (host, container, k8s, noop), including k8s private helpers (getMetrics, getContainersInPod, getContainerMetrics)
  • 20-second polling goroutine in internal/run.go that called p.GetMetrics and stuffed results onto node.Metrics
  • Metrics field from TaskNode

UI (internal/index.html)

  • Removed #metrics CSS rule, <span id="metrics"> DOM element, formatMetrics() JS function, and all node.metrics data bindings in both the initial graph render and SSE update paths

Docs

  • Removed "real-time metrics" from the Web UI feature description in README.md

Copilot AI changed the title [WIP] Remove unused task metrics feature from the repository Remove unused task metrics feature Jun 26, 2026
Copilot AI requested a review from alexec June 26, 2026 00:31
@alexec alexec requested a review from Copilot June 26, 2026 00:39
@alexec alexec marked this pull request as ready for review June 26, 2026 00:39
@alexec

alexec commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

@copilot fix conflicts.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the previously implemented (but unused) task memory metrics pipeline end-to-end, including backend collection/parsing, propagation through TaskNode, and Web UI rendering, and updates documentation to match.

Changes:

  • Removed types.Metrics, the internal/metrics parsing helpers, and GetMetrics from the proc.Interface plus all implementations.
  • Removed the periodic metrics polling goroutine and eliminated the TaskNode.Metrics field.
  • Removed all metrics-related UI bindings/CSS/formatting and updated README to no longer claim “real-time metrics”.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Updates Web UI feature description to remove “real-time metrics” claim.
internal/types/metrics.go Deletes the Metrics struct type.
internal/task_node.go Removes TaskNode.Metrics JSON field.
internal/run.go Removes the 20s polling goroutine that collected/published metrics.
internal/proc/proc.go Removes GetMetrics from the proc.Interface.
internal/proc/noop.go Removes the noop metrics implementation and related import.
internal/proc/kubernetes.go Removes Kubernetes metrics aggregation/helpers and related imports/comments.
internal/proc/host.go Removes host ps-based metrics collection and related import.
internal/proc/container.go Removes container procfs metrics collection and related import.
internal/metrics/ps.go Deletes ps parsing helpers.
internal/metrics/procfs.go Deletes procfs parsing helpers.
internal/index.html Removes metrics DOM element, CSS, formatter, and data bindings in initial render + SSE updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

@copilot fix conflicts.

Conflicts are fixed in commit 83f61eb. I merged origin/main into this branch and resolved the merge issues while keeping the metrics-removal changes intact.

@alexec alexec enabled auto-merge (squash) June 26, 2026 19:36
@alexec alexec merged commit d7857a3 into main Jun 26, 2026
2 checks passed
@alexec alexec deleted the copilot/remove-unused-task-metrics-feature branch June 26, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants