Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instead of pushing back actual data and storing it, we can instead use the fact that we're only replaying bytes that have just been returned. This allows us to
rewind()a few bytes, instead of copying them into a buffer. This is possible due toblock.copyWithin. For cases where we only returned input bytes directly, this is even simpler, since we can store an offset, avoidsubarray, and subtract from the offset.Set of changes
read()inputonreader.tsto be offset based and defersubarraycallspushback()logic withrewind()copyUint8ArraywithslicereadUntilBoundaryon readerexpectTrailerwith directread()call