Skip to content

Conversation

@emuvente
Copy link
Collaborator

@emuvente emuvente commented Oct 3, 2019

No description provided.

@emuvente emuvente requested a review from mcstover October 3, 2019 01:42
@emuvente emuvente changed the title Force install idtoken-verifier version 1.2.0 AUTH-244 Force install idtoken-verifier version 1.2.0 Oct 3, 2019
Copy link
Collaborator

@mcstover mcstover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this based on a rebuild of the package-lock.json and will it persist if we install something new make updates that generates a new package-lock file?

@emuvente
Copy link
Collaborator Author

emuvente commented Oct 3, 2019

This came from this suggestion https://stackoverflow.com/a/48524488
I moved idtoken-verifier from 'required' to 'dependencies' with "version": "1.2.0", then deleted node_modules and ran npm install which then made the other changes. I think this will only change if we upgrade auth0-js, so we will need to keep an eye out for that happening

@emuvente emuvente merged commit 1fda1f8 into master Oct 3, 2019
@emuvente emuvente deleted the AUTH-244 branch October 3, 2019 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants