AUTH-247 show tip message for auth0 errors #1226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcstover
reviewed
Oct 11, 2019
| } else { | ||
| message = `${message} Please clear your cookies and try again.`; | ||
| } | ||
| if (eventId) { |
Collaborator
There was a problem hiding this comment.
Is the eventId only present when in "special" error scenarios?
Collaborator
Author
There was a problem hiding this comment.
The event id should be present after any message is sent to sentry. I think the only real case it will not be present is on the vm where sentry is disabled.
mcstover
reviewed
Oct 11, 2019
|
|
||
| if (!this.isServer) { | ||
| // delay loading of webauth until we've confirmed we're in the browser, | ||
| // as it complains about not having window |
Collaborator
There was a problem hiding this comment.
Guess this was fixed in some update?
Collaborator
Author
There was a problem hiding this comment.
Yes, with version 1.4.1 of idtoken-verifier auth0/idtoken-verifier@7e25214
mcstover
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.