Skip to content

Core-107 click interactions and tracking events for KivaClassicBasicL…#3266

Merged
BoulderBrains merged 7 commits into
masterfrom
Core-107
Sep 24, 2021
Merged

Core-107 click interactions and tracking events for KivaClassicBasicL…#3266
BoulderBrains merged 7 commits into
masterfrom
Core-107

Conversation

@BoulderBrains
Copy link
Copy Markdown
Contributor

@BoulderBrains BoulderBrains commented Sep 23, 2021

…oanCard

Core-107

  • Click interaction added to borrower image by wrapping it in a router-link.
    - There's a conditional in place that if allSharesReserved is true, we disable the < router-link > by converting it to a span tag.
  • Tracking info added for borrower image click and "Read more" cta button click added based on spec in ticket.

Comment thread src/components/LoanCards/KivaClassicBasicLoanCard.vue Outdated
Comment thread src/components/LoanCards/KivaClassicBasicLoanCard.vue Outdated
Comment thread src/components/LoanCards/KivaClassicBasicLoanCard.vue
Comment thread src/components/LoanCards/KivaClassicBasicLoanCard.vue Outdated
Comment thread src/components/LoanCards/KivaClassicBasicLoanCard.vue
Comment thread src/components/LoanCards/KivaClassicBasicLoanCard.vue
@BoulderBrains
Copy link
Copy Markdown
Contributor Author

BoulderBrains commented Sep 24, 2021

I'd like to get this merged into master branch and then work on the additional changes requested in slack and captured in CORE-110 & CORE-111

The conclusion of that discussion was the following work.

  • We will add the “Learn more” text link after the loan use statement,
  • When all loan shares are reserved,
    • we will replace the CTA button with the “another lender has selected this loan” message
    • Hide the “Learn more” text link
    • Remove the link from the image (This change is present in this code review)

@BoulderBrains BoulderBrains merged commit 69ed0dc into master Sep 24, 2021
@BoulderBrains BoulderBrains deleted the Core-107 branch September 24, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants