Skip to content

Conversation

@eddieferrer
Copy link
Contributor

…r profiles

ACK-252

After doing some research, it seems some platforms (looking at you Slack) will use either twitter: or og: or a combination of both, depending on what order they are rendered on the page.

This PR does a couple of things:

  • Add vmid to twitter:image in App.vue. This allows this property to be replaced by the twitter:image from SummaryCard
  • Add twitter equivalent meta tags to SummaryCard and LoanUse

@eddieferrer eddieferrer requested review from emuvente and mcstover March 8, 2022 20:16
Copy link
Collaborator

@emuvente emuvente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good additions!

Copy link
Collaborator

@mcstover mcstover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eddieferrer eddieferrer merged commit 9646a74 into main Mar 8, 2022
@eddieferrer eddieferrer deleted the ACK-252_borrower_share_improvements branch March 8, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants