Cash 463 #561
Merged
Cash 463 #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcstover
reviewed
Jan 15, 2019
|
|
||
| .help-lightbox { | ||
| margin: 1.2rem 0; | ||
| position: relative; |
Collaborator
There was a problem hiding this comment.
Why do we need to override global styles here (this block and breakpoint below)? Should these changes be made to the lightbox?
Contributor
Author
There was a problem hiding this comment.
This is a poorly named class, it's actually the text that triggers the help-lightbox.
Contributor
Author
There was a problem hiding this comment.
I'll update it to help-lightbox-trigger.
Contributor
Author
mcstover
approved these changes
Jan 15, 2019
Collaborator
mcstover
left a comment
mcstover
left a comment
There was a problem hiding this comment.
Good with 1 minor question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some basic css changes to meet requests in cash-463.