Open
Conversation
roger-in-kiva
approved these changes
Apr 13, 2026
cristhianDt
approved these changes
Apr 13, 2026
christian14b
approved these changes
Apr 13, 2026
mcstover
reviewed
Apr 13, 2026
| // if the sort option value is valid, set it as the sort to be returned | ||
| .forEach(value => { | ||
| const sortOption = sortOptions.find(o => o?.toLowerCase() === value); | ||
| const sortOption = sortOptions.find(o => o?.toLowerCase() === value?.toLowerCase()); |
Collaborator
There was a problem hiding this comment.
We should be able to add a check in the tests that fails without your update, then succeeds with your update...
Collaborator
There was a problem hiding this comment.
Agreed, what specifically was the issue with the links? It looks like the casing matched.
dyersituations
requested changes
Apr 13, 2026
Collaborator
dyersituations
left a comment
dyersituations
left a comment
There was a problem hiding this comment.
See comment about use case and adding tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://kiva.atlassian.net/jira/software/projects/MP/boards/275?selectedIssue=MP-2602