Cash 513 #707
Cash 513 #707
Conversation
| methods: { | ||
| toggleFavorite() { | ||
| this.$emit('favorite-toggled'); | ||
| if (this.isFavorite === false) { |
There was a problem hiding this comment.
Spoke with @BoulderBrains about incorporating this into GridLoanCard and LoanCardController instead.
| toggleFavorite() { | ||
| // optimistically toggle it locally first | ||
| this.isFavorite = !this.isFavorite; | ||
| // this.isFavorite = !this.isFavorite; |
There was a problem hiding this comment.
Prob should keep this. It sets the "optimistic value" and immediately shows the new expected star state.
| }); | ||
| } else { | ||
| this.$kvTrackEvent( | ||
| 'favorited', |
There was a problem hiding this comment.
This should be "Lending" to put it into the context of other lending flow events.
| _forEach(data.errors, ({ message }) => { | ||
| this.$showTipMsg(message, 'error'); | ||
| }); | ||
| } else { |
There was a problem hiding this comment.
You probably want to also set this.isFavorite just inside this else statement using the return value from your mutation "data".
| }).catch(error => { | ||
| console.error(error); | ||
| }); | ||
| this.isFavorite = !this.isFavorite; |
There was a problem hiding this comment.
this won't be necessary with the changes mentioned above.
… moving into GridLoanCard and LoanCardController
|
Alright, @mcstover I've made some changes after our discussion today and this is now working again. A couple things I still want to talk through with you.
|
|
This new branch has been created for the improvement of the favorite functionality work that we discussed through the course of this work: https://github.com/kiva/ui/tree/work-toward-improved-favoriting |
No description provided.