send notifications to stderr. use colorization on stdout or stderr only if a tty.#495
Merged
Merged
Conversation
denys-duchier
force-pushed
the
fix-logging-to-stderr
branch
from
b1abecb to
f4978fd
Compare
Member
|
Great, thanks :) |
inclement
added a commit
that referenced
this pull request
Nov 24, 2015
send notifications to stderr. use colorization on stdout or stderr only if a tty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch sends log messages to stderr. See e.g. the url below for why that's preferable:
http://www.jstorimer.com/blogs/workingwithcode/7766119-when-to-use-stderr-instead-of-stdout
basically stdout is for primary data, and stderr for ancillary data (erros, notifications, ...), and this separation plays well with combining processes using pipes. It improves on my previous patch in that log info when calling p4a from buildozer will no longer be thrown away.
I also modified colorization, whether on stdout or stderr, to happen only when the corresponding stream is a tty.