Skip to content
This repository was archived by the owner on May 7, 2025. It is now read-only.

Improve support for form field accessibility to cover both single-acc… #857

Merged
PavelHolec merged 1 commit into from
Nov 14, 2024
Merged

Improve support for form field accessibility to cover both single-acc… #857

PavelHolec merged 1 commit into from
Nov 14, 2024

Conversation

@PavelHolec
Copy link
Collaborator

@PavelHolec PavelHolec commented Nov 13, 2024 •
edited
Loading

The update should make it closer to native behaviour:

  1. when simple text-based components are provided, the component acts as a single accessibility element with "label", "value" and "hint" filled in
  2. when custom components are provided, the component acts as an accessibility wrapper over the existing separate accessibility elements.

Tested against the app UI tests.

@PavelHolec PavelHolec linked an issue Nov 13, 2024 that may be closed by this pull request
Fix accessibility label and value for AccessibilityLabelValueModifier #844
Closed
@PavelHolec PavelHolec self-assigned this Nov 13, 2024
@PavelHolec PavelHolec added bug Something isn't working accessibility Issues supporting accessibility features labels Nov 13, 2024
@PavelHolec PavelHolec force-pushed the 844-fix-accessibility-label-and-value-for-accessibilitylabelvaluemodifier branch 2 times, most recently from d8ffbb6 to bd60862 Compare November 14, 2024 09:20
@PavelHolec PavelHolec marked this pull request as ready for review November 14, 2024 09:20
@PavelHolec PavelHolec requested a review from a team as a code owner November 14, 2024 09:20
@PavelHolec PavelHolec force-pushed the 844-fix-accessibility-label-and-value-for-accessibilitylabelvaluemodifier branch from bd60862 to cdad609 Compare November 14, 2024 09:21
@PavelHolec PavelHolec requested a review from sjavora November 14, 2024 11:26
@PavelHolec
Improve support for form field accessibility to cover both single-acc…
dc3ce9f 
…essible element with simple text and composed element with custom views
@PavelHolec PavelHolec force-pushed the 844-fix-accessibility-label-and-value-for-accessibilitylabelvaluemodifier branch from cdad609 to dc3ce9f Compare November 14, 2024 11:33
@PavelHolec PavelHolec merged commit f822178 into main Nov 14, 2024
6 checks passed
@PavelHolec PavelHolec deleted the 844-fix-accessibility-label-and-value-for-accessibilitylabelvaluemodifier branch November 14, 2024 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sjavora sjavora sjavora approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PavelHolec PavelHolec

Labels

accessibility Issues supporting accessibility features bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix accessibility label and value for AccessibilityLabelValueModifier

3 participants

@PavelHolec @sjavora