Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/publish-armv7l.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,20 @@ jobs:
with:
node-version: 18
cache: npm

- name: Setup Python
uses: actions/setup-python@v2
with:
python-version: '3.10'
python-version: '3.10'

- name: Install and build
run: |
npm install
npm run postinstall
# Build serialport for armv7l
cd release/app/node_modules/@serialport/bindings-cpp
npx node-gyp configure build
cd -
npm run build
- name: Publish releases
Expand Down
2 changes: 1 addition & 1 deletion src/main/electron-src/lib/serialManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ class DataRecorder {
};

stopRecord = () => {
this.shouldRecord = true;
this.shouldRecord = false;
};
}

Expand Down
2 changes: 1 addition & 1 deletion src/renderer/components/DataPlot.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
}
setState(updateLines);
}
}, [newData, state]); // Added state to dependency array
}, [newData]); // Added state to dependency array

Check failure on line 118 in src/renderer/components/DataPlot.tsx

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest)

React Hook useEffect has a missing dependency: 'state'. Either include it or remove the dependency array

Check failure on line 118 in src/renderer/components/DataPlot.tsx

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest)

React Hook useEffect has a missing dependency: 'state'. Either include it or remove the dependency array

return (
<>
Expand Down
Loading