Fix handling of repeating groups with padding#26
Merged
kizzx2 merged 1 commit intokizzx2:masterfrom Dec 20, 2024
Merged
Conversation
Contributor
gburca
commented
Dec 18, 2024
gburca
commented
- If the group specifies a blockLength greater than the calculated (natural) group size, we need to add padding after each group.
- The groupSizeEncoding must report the specified blockLength so the decoder can skip over padding.
- Fix a typo in the schema
- If the group specifies a blockLength greater than the calculated (natural) group size, we need to add padding after each group. - The groupSizeEncoding must report the specified blockLength so the decoder can skip over padding. - Fix a typo in the schema
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.