Build for Windows + PHP 8.5

[jnoordsij]

Summary by CodeRabbit

• Chores
  • Expanded Windows CI testing pipeline to include PHP 8.5 compatibility verification across supported configurations.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

A GitHub Actions workflow file is updated to add PHP 8.5 to the Windows CI matrix with an exclusion rule preventing the combination of PHP 8.5 with VS16 toolchain from running.

Changes

Cohort / File(s)	Summary
CI Workflow Configuration .github/workflows/windows.yaml	Adds PHP 8.5 to the build matrix and excludes the PHP 8.5 + VS16 combination from CI runs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Simple YAML configuration additions with no logic or control flow changes.

Poem

🐰 A rabbit hops through CI lands so bright,
Where PHP 8.5 joins the Windows night,
But VS16? Skip that pair with care,
The workflows dance without a snare! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: adding PHP 8.5 support to the Windows CI build matrix.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 03d07dc and 04b18df.

📒 Files selected for processing (1)

• .github/workflows/windows.yaml (2 hunks)

🔇 Additional comments (2)

.github/workflows/windows.yaml (2)

18-18: PHP 8.5 matrix addition is timely and well-placed.

PHP 8.5.0 was released on 2025-11-20 with Windows binaries available, making this addition appropriate for immediate CI testing. The placement is correct as the first (newest) version in the matrix.

---

36-37: Exclude rule follows established pattern for toolchain constraints.

The exclusion of PHP 8.5 with VS16 mirrors the existing pattern where PHP 8.4 also excludes VS16, while older versions (8.3, 8.2, 8.1) exclude VS17. This suggests newer PHP releases require the newer VS17 toolchain.

Consider adding a comment in the workflow to document why each PHP version excludes a specific toolchain (e.g., # PHP 8.5+ requires VS17), which would aid future maintainers. This is optional but would improve documentation clarity.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}