Skip to content

Conversation

@jnoordsij
Copy link
Contributor

@jnoordsij jnoordsij commented Nov 26, 2025

See also https://github.com/google/brotli/releases/tag/v1.2.0

Summary by CodeRabbit

  • Chores

    • Updated bundled Brotli to a newer tracked revision.
    • Enhanced build configuration for Windows and Unix to include additional Brotli modules for improved compression support.
  • Tests

    • Added a new compression compatibility test case covering an additional compressed sample.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

Walkthrough

Brotli submodule updated to a newer commit; build scripts for Unix and Windows extended to include four additional Brotli source files for encoder/decoder; a new compatibility test entry for zerosukkanooa.compressed was added.

Changes

Cohort / File(s) Summary
Submodule Pointer Update
brotli
Submodule reference advanced from commit ed738e8... to 028fb5a...; no source or build logic changes in the tracked tree itself.
Unix build config
config.m4
Added bundled Brotli source files to encoder/decoder lists: brotli/c/enc/static_dict_lut.c, brotli/c/enc/static_init.c, brotli/c/dec/prefix.c, brotli/c/dec/static_init.c.
Windows build config
config.w32
Reworked ADD_SOURCES invocation to grouped file lists and explicit include paths; added brotli\c\common\static_dict_lut.c, brotli\c\common\static_init.c, brotli\c\enc\static_dict.c, brotli\c\enc\static_dict_lut.c, brotli\c\enc\static_init.c, brotli\c\enc\utf8_util.c, brotli\c\dec\prefix.c, brotli\c\dec\static_init.c and explicit library/path arguments.
Test addition
tests/compatibility.phpt
Added a compatibility test case for zerosukkanooa.compressed exercising read/uncompressed, compressed, and uncompressed checks.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Verify the added source paths match the updated Brotli submodule layout.
  • Confirm config.w32 grouped ADD_SOURCES format preserves compiler flags and include paths.
  • Ensure config.m4 additions integrate with existing BROTLI_* source lists and autoconf logic.
  • Validate the new test entry follows existing patterns and the referenced compressed file exists in tests.

Poem

🐰
Hoppity-hop, a submodule new,
Static bits and init files too,
Build scripts tidy, paths aligned,
A test hops in to check and find,
Crunching bytes — a rabbit's cheer! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update brotli submodule to v1.2.0' directly and clearly describes the main change in the pull request: upgrading the brotli submodule to version 1.2.0, which is confirmed by the submodule pointer update and the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3150cd5 and 8268a06.

📒 Files selected for processing (1)
  • config.w32 (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • config.w32

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kjdev
Copy link
Owner

kjdev commented Nov 27, 2025

Please fix the U4004 error occurring during Windows module build.

NMAKE : warning U4004: too many rules for target 'D:\a\php-ext-brotli\php-ext-brotli\Release\\static_init.obj'

Specify the fourth argument of ADD_SOURCES() in config.w32.

    ADD_SOURCES("brotli/c/enc", "backward_references.c backward_references_hq.c bit_cost.c block_splitter.c brotli_bit_stream.c cluster.c command.c compound_dictionary.c compress_fragment.c compress_fragment_two_pass.c dictionary_hash.c encode.c encoder_dict.c entropy_encode.c fast_log.c histogram.c literal_cost.c memory.c metablock.c static_dict.c static_dict_lut.c static_init.c utf8_util.c", "brotli", "brotli\\c\\enc");
    ADD_SOURCES("brotli/c/dec", "bit_reader.c decode.c huffman.c prefix.c state.c static_init.c", "brotli", "brotli\\c\\dec");

@jnoordsij
Copy link
Contributor Author

Done! I've also taken the liberty to split all the files over multiple lines, like in the Linux equivalent, to slightly improve readability and allow for easier comparison.

@kjdev kjdev merged commit 3b3d9e3 into kjdev:master Nov 27, 2025
133 of 139 checks passed
@kjdev
Copy link
Owner

kjdev commented Nov 27, 2025

Thanks.

@jnoordsij jnoordsij deleted the brotli-v1.2.0 branch November 28, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants