-
Notifications
You must be signed in to change notification settings - Fork 29
Update brotli submodule to v1.2.0 #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughBrotli submodule updated to a newer commit; build scripts for Unix and Windows extended to include four additional Brotli source files for encoder/decoder; a new compatibility test entry for Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Please fix the U4004 error occurring during Windows module build. Specify the fourth argument of ADD_SOURCES() in config.w32. |
|
Done! I've also taken the liberty to split all the files over multiple lines, like in the Linux equivalent, to slightly improve readability and allow for easier comparison. |
|
Thanks. |
See also https://github.com/google/brotli/releases/tag/v1.2.0
Summary by CodeRabbit
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.