feat: add token source position tracking to lexer#22
Open
label-hook[bot] wants to merge 1 commit intomasterfrom
Open
feat: add token source position tracking to lexer#22label-hook[bot] wants to merge 1 commit intomasterfrom
label-hook[bot] wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional token source position tracking to the sqlparse lexer to support use cases like syntax highlighting. This enhancement allows users to track the character position of each token in the original SQL string while maintaining full backwards compatibility.
Changes
tokenize()method unchanged, new functionality available through optional parametersKey Implementation Details
sqlparse/lexer.pyto track character positions during tokenizationsqlparse/filters/tokens.pyto gracefully handle both 2-tuple and 3-tuple tokenssqlparse/engine/filter_stack.pyto support position-aware token processingsqlparse/sql.pyToken class to optionally store and provide access to position informationTesting
Comprehensive test coverage added to verify:
All existing tests continue to pass, ensuring no breaking changes to the current API.
Closes #17
Closes #17