Skip to content
This repository was archived by the owner on Jul 23, 2024. It is now read-only.

Conversation

@sirano11
Copy link

@sirano11 sirano11 commented Nov 25, 2020

Proposed changes

This PR has the following contents.

  • Defined the IWallet interface and implemented it to the KeyringContainer class.
  • To use IWallet interface in Contract class, modify return type Caver@getWallet()
    • also when signing in Contract class, it modified code to caver.getWallet().sign()

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@sirano11 sirano11 requested a review from jimni1222 November 25, 2020 08:17
@sirano11 sirano11 requested a review from kjhman21 as a code owner November 25, 2020 08:17
@sirano11 sirano11 self-assigned this Nov 25, 2020
jimni1222
jimni1222 previously approved these changes Nov 26, 2020
Copy link
Contributor

@jimni1222 jimni1222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for minor comment :)

Co-authored-by: Jasmine <32922423+jimni1222@users.noreply.github.com>
@sirano11 sirano11 dismissed stale reviews from jimni1222 via e10063d November 26, 2020 01:10
@sirano11 sirano11 merged commit 25602bf into klaytn:dev Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants