Skip to content
This repository was archived by the owner on Jul 23, 2024. It is now read-only.

Conversation

@sirano11
Copy link

@sirano11 sirano11 commented Dec 7, 2020

Proposed changes

This PR clarify the exception class thrown by the method(sign, signAsFeePayer) in IWallet interface.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@sirano11 sirano11 requested a review from jimni1222 December 7, 2020 02:31
@sirano11 sirano11 self-assigned this Dec 7, 2020
@sirano11 sirano11 requested a review from kjhman21 as a code owner December 7, 2020 02:31
@sirano11 sirano11 merged commit c472d37 into klaytn:dev Dec 7, 2020
@sirano11 sirano11 deleted the modify_IWallet_throw branch December 7, 2020 04:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants