Skip to content
This repository was archived by the owner on Jul 23, 2024. It is now read-only.

Conversation

@sirano11
Copy link

Proposed changes

This PR clarify throws exception class in KIP7 / KIP17

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@sirano11 sirano11 requested a review from jimni1222 December 15, 2020 00:58
@sirano11 sirano11 self-assigned this Dec 15, 2020
@sirano11 sirano11 requested a review from kjhman21 as a code owner December 15, 2020 00:58
jimni1222
jimni1222 previously approved these changes Dec 15, 2020
@sirano11 sirano11 merged commit 3f28f8d into klaytn:dev Dec 15, 2020
@sirano11 sirano11 deleted the clarify_exception branch July 20, 2021 04:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants