This repository was archived by the owner on Jul 23, 2024. It is now read-only.
Fix "Duplicated Account" problem caused by KeyringContainer.remove()
#227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fix "Duplicated Account" problem caused by
KeyringContainer.remove().Because
Keyring Container.add()andKeyring Container.get Keyring()both use lower cased address,Keyring Container.remove()should guarantee its input address is lower cased.You can re-produce error by following below sequence.
caver.wallet.add()with address having lower and capital letter both. (e.g.0xca04A7e79072CE7edd3C1B0bFAdDe496806a16AD)caver.wallet.updateKeyring()with new keyring which have same address in sequence 1 and different private key."Duplicated Account. Please use updateKeyring() instead".Here is the Gist RemoveErrorTest.java for more detail. You can test yourself with this Gist and KAS
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...