Skip to content
This repository was archived by the owner on Jul 23, 2024. It is now read-only.

Conversation

@aeharvlee
Copy link
Contributor

Proposed changes

This PR fix "Duplicated Account" problem caused by KeyringContainer.remove().

Because Keyring Container.add() and Keyring Container.get Keyring() both use lower cased address,
Keyring Container.remove() should guarantee its input address is lower cased.

You can re-produce error by following below sequence.

  1. Add your keyring to wallet using caver.wallet.add() with address having lower and capital letter both. (e.g. 0xca04A7e79072CE7edd3C1B0bFAdDe496806a16AD)
  2. Update your keyring using caver.wallet.updateKeyring() with new keyring which have same address in sequence 1 and different private key.
  3. Then you can see the error "Duplicated Account. Please use updateKeyring() instead".

Here is the Gist RemoveErrorTest.java for more detail. You can test yourself with this Gist and KAS

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Because KeyringContainer.add and KeyringContainer.getKeyring both use lowerCased address,
KeyringContainer.remove should change it's input address to lowercase.
@aeharvlee aeharvlee requested a review from sirano11 May 7, 2021 00:07
@aeharvlee aeharvlee self-assigned this May 7, 2021
jimni1222
jimni1222 previously approved these changes May 7, 2021
@aeharvlee aeharvlee merged commit 345df6c into klaytn:dev May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants