This repository was archived by the owner on Jul 23, 2024. It is now read-only.
Support fee delegation and sign functions in Contract. #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
May 10, 2021 14:33
jimni1222
reviewed
May 18, 2021
jimni1222
reviewed
May 18, 2021
jimni1222
reviewed
May 18, 2021
jimni1222
reviewed
May 18, 2021
core/src/main/java/com/klaytn/caver/contract/ContractMethod.java
Outdated
Show resolved
Hide resolved
jimni1222
reviewed
May 18, 2021
core/src/main/java/com/klaytn/caver/contract/ContractMethod.java
Outdated
Show resolved
Hide resolved
jimni1222
reviewed
May 18, 2021
jimni1222
reviewed
May 18, 2021
jimni1222
reviewed
May 18, 2021
core/src/main/java/com/klaytn/caver/contract/ContractMethod.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jasmine <32922423+jimni1222@users.noreply.github.com>
…yer address is valid in send().
jimni1222
reviewed
May 23, 2021
jimni1222
reviewed
May 23, 2021
jimni1222
reviewed
May 23, 2021
jimni1222
reviewed
May 23, 2021
Co-authored-by: Jasmine <32922423+jimni1222@users.noreply.github.com>
jimni1222
approved these changes
May 24, 2021
Contributor
jimni1222
left a comment
jimni1222
left a comment
There was a problem hiding this comment.
LGTM =) Thank you for your hard working!
aeharvlee
approved these changes
May 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR supports fee delegation and sign function in
ContractandContractMethodclass.SendOptionsSendOptionsTypes of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...