Skip to content
This repository was archived by the owner on Jul 23, 2024. It is now read-only.

Conversation

@aeharvlee
Copy link
Contributor

Proposed changes

This PR updated the logic about decrypting keystore file.
Decryption logic must be able to handle a keystore file having address without the hex prefix '0x'.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

aeharvlee added 2 commits June 9, 2021 14:56
The keystore file decryption logic
must be able to handle keystore files
with addresses without the hex prefix '0x'.
@aeharvlee aeharvlee requested a review from jimni1222 as a code owner June 9, 2021 06:02
@aeharvlee aeharvlee self-assigned this Jun 9, 2021
@aeharvlee aeharvlee merged commit 6060884 into klaytn:dev Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants