This repository was archived by the owner on Jul 23, 2024. It is now read-only.
[Master] release/v1.6.3 QA Sign-off #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CI to test seperately
Update CI to test seperately
1. Moved `no_output_timeout` from build_test_android step to instrumented test step The `no_output_timeout` option was added to prevent Gradle from sometimes deadlocking during instrumentation tests. What build_test_android step do is just building without any tests, we don't have to put it here. The right place of the option is the step doing instrumented testing on android emulator. 2. Increase the timeout value in case the test takes a long time 3. Change name of build_android_test step This step does just building so name should describe this.
Co-authored-by: kale <kale.kim@groundx.xyz>
CircleCI has a built-in 10 minute no-output timeout. This means that if it has been 10 minutes since the last output, the build will be canceled and stopped. So 20m is enough to check whether dead-lock happened or not.
Updated circle ci config
updated version
Add a network provider field in Caver class.
Separate the library of web3j used in accordance with the project version
Update version 2 to 2.1
[CIRCLECI] Update version 2 to 2.1
circleci-klaytn
requested review from
aeharvlee,
jimni1222,
kjhman21 and
sirano11
as code owners
Fixed typo at method name
Fixed a encode / decode logic that if the length of array that has dynamic size has zero
…sponding to the vote key.
added 5 commits
July 30, 2021 11:31
add a recover public key methods from transaction.
add validateSender/FeePayer/Transaction.
caver-java v1.6.3 QA result
|
aeharvlee
previously approved these changes
Aug 9, 2021
michael-gx
previously approved these changes
Aug 11, 2021
added 2 commits
August 11, 2021 09:38
modified keyRing field name to keyring in KeyStore class.
whoisxx
dismissed stale reviews from michael-gx, aeharvlee, and jimni1222
via
5722c5a
whoisxx
force-pushed
the
release/v1.6.3
branch
from
c9b9080 to
5722c5a
Compare
jimni1222
previously approved these changes
Aug 11, 2021
aeharvlee
previously approved these changes
Aug 11, 2021
sirano11
previously approved these changes
Aug 11, 2021
michael-gx
previously approved these changes
Aug 11, 2021
sirano11
dismissed stale reviews from michael-gx, aeharvlee, jimni1222, and themself
via
9b9c838
sirano11
approved these changes
Aug 11, 2021
aeharvlee
approved these changes
Aug 11, 2021
jimni1222
approved these changes
Aug 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is automatically created by CI to release a new official version of caver-java.
When this PR is approved by QA team, a new version will be released.