This repository was archived by the owner on Jul 23, 2024. It is now read-only.
Updated Default Gas Provider #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefaultGasProvider now implements ContractGasProvider instead of extends StaticGasProvider to provide dynamic gas price value based on network. Because Klaytn is now planning to apply dynamic gas price policy. If that policy is activated and we does not change this behavior, there is a high probability that the transactions created using the SDK cannot be processed.
jimni1222
reviewed
Jun 24, 2022
jimni1222
reviewed
Jun 24, 2022
core/src/main/java/com/klaytn/caver/tx/gas/DefaultGasProvider.java
Outdated
Show resolved
Hide resolved
jimni1222
reviewed
Jun 24, 2022
Change Gas Price variable name. Remove un-necessary deprecated tag which is duplicate (already tagged at Class). Klaytn node in the klaytn:build docker image returns protocol version as 0x41.
It should be return 0x40(=64)
protocol versions can be different. So it should not be checked with specific value in the test code.
jimni1222
reviewed
Jun 27, 2022
core/src/main/java/com/klaytn/caver/tx/gas/DefaultGasProvider.java
Outdated
Show resolved
Hide resolved
jimni1222
approved these changes
Jun 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
DefaultGasProvidernow implementsContractGasProviderinstead of extendingStaticGasProviderto provide dynamic gas price value based on network.DefaultGasProviderto get dynamic gas price from network.@Depreatedtag additionally to emphasize "user should not use this constructor".DefaultGasProviderTypes of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...