This repository was archived by the owner on Jul 23, 2024. It is now read-only.
Apply api naming convention #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjeom
requested review from
JayChoi1736,
henry-will,
jimni1222 and
kjhman21
as code owners
Author
|
I have read the CLA Document and I hereby sign the CLA |
kjeom
force-pushed
the
applyAPINamingConvention
branch
2 times, most recently
from
a69f827 to
b5dad98
Compare
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
kjeom
force-pushed
the
applyAPINamingConvention
branch
from
b5dad98 to
61be717
Compare
kjhman21
previously approved these changes
Mar 16, 2023
JayChoi1736
reviewed
Mar 17, 2023
| } | ||
| public String getKgf() { | ||
| return this.kgf; | ||
| public String getKff() { |
Contributor
There was a problem hiding this comment.
minor thing: don't we need to change "kir" or "poc" in GovernanceStakingInfo.java like this?
Author
There was a problem hiding this comment.
You are right, thanks. The test passed because It doesn't check every field.
JayChoi1736
approved these changes
Mar 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
getItemsAtandgetChainConfigAtAPIs is replaced bygetParamsandgetChainConfigrespectively.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.