Skip to content

feat(KLEF-115-116): Create plugin standard and plugin marketplace#2

Merged
isaacwallace123 merged 4 commits intomainfrom
feat/kleff-115-116_Create_Plugin_Standard_And_Plugin_Marketplace
Apr 2, 2026
Merged

feat(KLEF-115-116): Create plugin standard and plugin marketplace#2
isaacwallace123 merged 4 commits intomainfrom
feat/kleff-115-116_Create_Plugin_Standard_And_Plugin_Marketplace

Conversation

@JeremyNRoos
Copy link
Copy Markdown
Contributor

Pull Request

Summary

  • Adds EnsureAdmin RPC to the IdentityPlugin gRPC service contract
  • Provides a standard hook for any IDP plugin to seed its admin user and assign the platform admin role on demand

Related Issues

Closes #


Changes

What's Included

  • Added EnsureAdminRequest and EnsureAdminResponse types to v1/types.go
  • Added EnsureAdmin to IdentityPluginClient interface and concrete client implementation in v1/idp.go
  • Added EnsureAdmin to IdentityPluginServer interface and UnimplementedIdentityPluginServer in v1/idp.go
  • Added EnsureAdmin entry to IdentityPlugin_ServiceDesc.Methods and its handler function _IdentityPlugin_EnsureAdmin_Handler

What's Not Included

  • Platform-side caller (manager.go) — will be wired once this SDK version is published and consumed upstream
  • No changes to the health, middleware, UI, or HTTP route service contracts

Testing

How Was This Tested?

  • SDK builds cleanly with go build ./...
  • Verified the new method follows the same pattern as all other existing methods

Test Coverage

  • Unit tests added or updated
  • Integration tests added or updated
  • Manually tested end-to-end

Breaking Changes

Does this PR introduce breaking changes?

  • Yes
  • No

UnimplementedIdentityPluginServer provides a default implementation, so existing plugin servers that embed it are not broken.


Security Considerations

  • This PR affects authentication or authorization logic
  • This PR touches secrets, tokens, or environment variables
  • This PR affects infrastructure, deployment pipelines, or network configuration

EnsureAdmin triggers admin user seeding and role assignment inside the IDP. The RPC is called by the platform immediately after plugin install — it is not exposed externally.


Documentation

Does this PR require documentation updates?

  • Yes
  • No

UI/UX (If Applicable)

N/A


Pre-Merge Checklist

  • PR title follows semantic format (feat:, fix:, chore:, docs:, refactor:, test:)
  • All CI checks passing
  • Code follows project style guidelines
  • No debug logs or commented-out code left in
  • Dependencies reviewed (no unnecessary additions)
  • No sensitive information included

Reviewer Notes

@JeremyNRoos JeremyNRoos self-assigned this Apr 2, 2026
@isaacwallace123 isaacwallace123 merged commit 10a3542 into main Apr 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants