Arbitrator devnet redeploy #84
Conversation
✅ Deploy Preview for curate-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Caution Review failedThe pull request is closed. WalkthroughThe changes update the Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant HH as Hardhat
participant Core as KlerosCore Contract
participant Evidence as Evidence Contract
participant CurateV2 as CurateV2 Contracts
participant Factory as CurateFactory Contract
Dev->>HH: Run "change-arbitrator" task
HH->>Core: Get KlerosCore instance
HH->>Evidence: Get Evidence instance
HH->>CurateV2: Get master CurateV2 contract
HH->>CurateV2: changeArbitrationParams(master)
HH->>Factory: Get CurateFactory contract
Factory->>HH: Emit NewList events (all CurateV2 deployed)
loop For each CurateV2 instance
HH->>CurateV2: Check governor
alt Governor is deployer
HH->>CurateV2: changeArbitrationParams(instance)
else
HH->>HH: Skip update
end
end
HH->>HH: Run "set-dispute-template" task
HH->>Dev: Log transaction hashes and updates complete
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
web/package.json (1)
49-51: Version alignment LGTM
Frontend devDependency now matches the contracts workspace, preventing mismatched ABIs during codegen. Remember to runyarn install(which re-creates the lockfile) before pushing the tag.templates/index.ts (1)
1-18: Consider externalising all “devnet constants” into a single config module
The top-level comment already flags the tech debt; with every devnet redeploy we touch multiple literals here. MovingarbitratorAddress,arbitrableChainID, etc., to a.envfile or shared JSON would eliminate manual edits and reduce merge conflicts.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (3)
contracts/package.json(1 hunks)templates/index.ts(1 hunks)web/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - curate-v2
- GitHub Check: Header rules - curate-v2
- GitHub Check: Pages changed - curate-v2
🔇 Additional comments (2)
contracts/package.json (1)
88-90: Confirm compatibility of@kleros/kleros-v2-contracts@^0.10.0bump
We’ve located imports of@kleros/kleros-v2-contractsin your codebase—this upgrade is pre-1.0 so may include breaking changes:• contracts/wagmi.config.testnet.ts
• contracts/wagmi.config.mainnet.ts
• contracts/wagmi.config.devnet.ts
• contracts/src/CurateV2.sol
• contracts/deploy/00-curate-v2.tsPlease run:
hardhat compile && yarn test yarn typechainand verify that:
- TypeChain types still build without errors.
- Any constructor or ABI changes in v2 contracts are reflected in your deployment scripts and mocks.
Confirm before merging.templates/index.ts (1)
8-11: New devnet arbitrator address acknowledged – verify it’s the one emitted by v0.10 deploys
Given the hard-coded nature of this file, please sanity-check that0x1Bd44c4a4511DbFa7DC1d5BC201635596E7200f9is the arbitrator address in the freshly deployed devnet (chain ID 421614).
bumped @kleros/kleros-v2-contracts to pick up the latest devnet contracts
PR-Codex overview
This PR primarily updates the version of the
@kleros/kleros-v2-contractspackage from^0.9.3to^0.10.0and introduces new functionality for managing dispute templates and changing arbitrators within the smart contract framework.Detailed summary
@kleros/kleros-v2-contractsversion to^0.10.0inpackage.jsonfiles.CurateV2master copy insetDisputeTemplate.ts.changeArbitrator.tsscript to change arbitrators for curated lists.getDisputeTemplatetask to retrieve dispute templates by ID.arbitratorAddressintemplates/index.ts.yarn.lock.Summary by CodeRabbit
Chores
Refactor
New Features