Skip to content

Fix/chain id iframe encoding #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2025
Merged

Fix/chain id iframe encoding #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae621c3
fix: parse chain IDs when builindg iframe URL
kyrers Nov 10, 2025
56eca97
fix: standardize address casing in arbitrableWhitelist
kyrers Nov 10, 2025
f7d7d0b
fix: wrong iframe source URL param name
kyrers Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/components/disputeSummary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,29 +12,29 @@ class DisputeSummary extends React.Component {
const { arbitratorDisputeID, arbitratorAddress, arbitratorChainID, chainID, web3Provider } = this.props;
return {
disputeID: arbitratorDisputeID,
chainID,
chainID: Number.parseInt(chainID, 10),
arbitratorContractAddress: arbitratorAddress,
arbitratorJsonRpcUrl: getReadOnlyRpcUrl({ chainId: arbitratorChainID }) ?? web3Provider,
arbitratorChainID,
arbitratorChainID: Number.parseInt(arbitratorChainID, 10),
};
}

getArbitrableConfig() {
const { arbitrableChainID, arbitrated, web3Provider } = this.props;
return {
arbitrableContractAddress: arbitrated,
arbitrableChainID,
arbitrableChainID: Number.parseInt(arbitrableChainID, 10),
arbitrableJsonRpcUrl: getReadOnlyRpcUrl({ chainId: arbitrableChainID }) ?? web3Provider,
};
}

getInjectedArgs() {
const { web3Provider, chainID } = this.props;
// Convert web3Provider object to URL string if needed
const jsonRpcUrl = typeof web3Provider === 'object'
? getReadOnlyRpcUrl({ chainId: chainID })
const jsonRpcUrl = typeof web3Provider === 'object'
? getReadOnlyRpcUrl({ chainId: chainID })
: web3Provider;

// Follow Kleros Court approach: only pass essential parameters
// Do NOT pass block range parameters - let evidence interfaces handle optimization internally
const baseArgs = {
Expand All @@ -58,7 +58,7 @@ class DisputeSummary extends React.Component {

renderAliases(metaevidenceJSON) {
if (!metaevidenceJSON.aliases) return null;

return (
<Row>
{Object.entries(metaevidenceJSON.aliases).map(([key, value]) => (
Expand Down
6 changes: 3 additions & 3 deletions src/ethereum/arbitrableWhitelist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const arbitrableWhitelist = {
"0xf339047c85d0dd2645f2bd802a1e8a5e7af61053",
"0xf65c7560d6ce320cc3a16a07f1f65aab66396b9e",
"0xf72cfd1b34a91a64f9a98537fe63fbab7530adca",
"0xbE9834097A4E97689d9B667441acafb456D0480A"
"0xbe9834097a4e97689d9b667441acafb456d0480a"
],
100: [
"0x0b928165a67df8254412483ae8c3b8cc7f2b4d36",
Expand All @@ -50,10 +50,10 @@ const arbitrableWhitelist = {
"0xd5994f15be9987104d9821aa99d1c97227c7c08c",
"0xe04f5791d671d5c4e08ab49b39807087b591ea3e",
"0xf7de5537ecd69a94695fcf4bcdbdee6329b63322",
"0xa4AC94C4fa65Bb352eFa30e3408e64F72aC857bc"
"0xa4ac94c4fa65bb352efa30e3408e64f72ac857bc"
],
8453: [
"0xF0b37Feda6CDF5F78B37e1Fbccc24969059F2044"
"0xf0b37feda6cdf5f78b37e1fbccc24969059f2044"
]
};

Expand Down
Loading