Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Conversation

@satello
Copy link
Contributor

@satello satello commented May 8, 2018

  • Add Auth as a resource. It is included in the base kleros api as kleros.auth.
  • Pass Auth token in header when we make POST or PUT requests.
  • Add methods to sign auth tokens and validate auth tokens
  • Restructure StoreProvider methods that pulled from shared store data that has been removed.
  • Restructure event listeners that interact with the Store.

@satello satello requested review from epiqueras and n1c01a5 May 8, 2018 20:58
@coveralls
Copy link

coveralls commented May 8, 2018

Pull Request Test Coverage Report for Build 660

  • 24 of 87 (27.59%) changed or added relevant lines in 10 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 43.272%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/constants/error.js 2 3 66.67%
src/kleros.js 2 3 66.67%
src/contracts/abstractions/Arbitrable.js 0 3 0.0%
src/resources/Notifications.js 0 3 0.0%
src/utils/Web3Wrapper.js 0 4 0.0%
src/resources/Auth.js 8 15 53.33%
src/utils/StoreProviderWrapper.js 1 23 4.35%
src/resources/Disputes.js 7 29 24.14%
Files with Coverage Reduction New Missed Lines %
src/resources/Notifications.js 1 27.4%
src/resources/Disputes.js 2 38.86%
src/utils/StoreProviderWrapper.js 2 1.96%
Totals Coverage Status
Change from base Build 658: -0.1%
Covered Lines: 434
Relevant Lines: 868

💛 - Coveralls

@satello satello force-pushed the feat/add_store_auth branch from f69cf29 to 3421db0 Compare May 9, 2018 14:52
@satello satello force-pushed the feat/add_store_auth branch from 3421db0 to 9042b21 Compare May 22, 2018 23:38
@satello satello merged commit c0bfb62 into develop May 23, 2018
@satello satello deleted the feat/add_store_auth branch May 23, 2018 07:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants