Skip to content
This repository was archived by the owner on Mar 16, 2022. It is now read-only.

Fix sidebar error story #81

Merged
merged 4 commits into from
Jan 5, 2018
Merged

Fix sidebar error story #81

merged 4 commits into from
Jan 5, 2018

Conversation

M-ZubairAhmed
Copy link
Contributor

Issue

screenshot from 2018-01-03 20-22-57

  • Error as above was shown when navigating to storybooks server-Sidebar section

Solution

  • Attached story with redux Provider using addDecoratorapi to connect the store to sidebar
  • Converted address prop of sidebar to string
  • Included Storybook for account locked sidebar scenario

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0005%) to 0.313% when pulling cdc8c55 on M-ZubairAhmed:fix-sidebar-err-story into ebce583 on kleros:develop.

@M-ZubairAhmed
Copy link
Contributor Author

If everythings fine please merge #80 before the current pr

@n1c01a5 n1c01a5 merged commit 685ab5b into kleros:develop Jan 5, 2018
@M-ZubairAhmed M-ZubairAhmed deleted the fix-sidebar-err-story branch January 5, 2018 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@M-ZubairAhmed @coveralls @n1c01a5