Feat: updated lastInteraction when task is resolved #309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently there is a problem to identify exactly when a task is marked as resolved.
So far I identified the following use case:
There are probably more though.
Risk Analysis
Regarding the risks introduced by such changes: all methods that perform some sort of verification on
lastInteraction:assignTaskkleros-interaction/contracts/standard/arbitration/Linguo.sol
Line 215 in 0e27cc7
submitTranslationkleros-interaction/contracts/standard/arbitration/Linguo.sol
Line 243 in 0e27cc7
reimburseRequesterkleros-interaction/contracts/standard/arbitration/Linguo.sol
Line 257 in 0e27cc7
challengeTranslationkleros-interaction/contracts/standard/arbitration/Linguo.sol
Line 289 in 0e27cc7
All of them:
statusguard.statusif all conditions are met. This means other transactions that depend on the previouslastInteractionwould not be allowed anyway.Cost Analysis
Marginal cost for this change would be as high as
20,000gas (SSTOREgas spending according to this).