review: Matt's linguo review #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eccentricexit
changed the title
Contributor
|
Adding evidence parameter sounds like a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes no changes to logic, only comments and a variable name.
In addition, I'd like to propose the following change:
I believe the
challengeTranslationshould accept another parameterstring _evidenceto allow challenging and submitting an evidence at the same time.On the T2CR there were cases where the challenger would delay submitting the justification as much as possible, to make it difficult for the defendant to make a proper response in a timely manner. With this additional field we can require at the policy level that the challenger provide at least a basic summary of the accusation in order to not lose the case.