Skip to content
This repository was archived by the owner on Jul 1, 2022. It is now read-only.

Conversation

@satello
Copy link
Contributor

@satello satello commented Nov 8, 2018

  • Move dispute fetching logic from api into fetchDispute since it is mixed and matched with archon now and we don't need a lot of the data returned from kleros.dispute.getDataForDispute anymore so we can stop using it.
  • Updated the dispute display terminology to be consistent with standards.

@satello satello requested a review from epiqueras November 8, 2018 05:52
@coveralls
Copy link

coveralls commented Nov 8, 2018

Pull Request Test Coverage Report for Build 505

  • 0 of 61 (0.0%) changed or added relevant lines in 5 files are covered.
  • 202 unchanged lines in 26 files lost coverage.
  • Overall coverage decreased (-9.3%) to 17.204%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/iframes/doges-on-trial-evidence/index.js 0 1 0.0%
src/containers/dispute/components/ruling/index.js 0 1 0.0%
src/containers/dispute/components/details/index.js 0 3 0.0%
src/containers/dispute/components/evidence/index.js 0 14 0.0%
src/sagas/dispute.js 0 42 0.0%
Files with Coverage Reduction New Missed Lines %
src/sagas/dispute.js 1 0.7%
src/chainstrap/actions/tooltip.js 2 0.0%
src/chainstrap/components/index.js 2 0.0%
src/containers/dispute/components/ruling/index.js 2 0.0%
src/chainstrap/index.js 3 0.0%
src/chainstrap/chain-view/reducers/index.js 3 0.0%
src/chainstrap/chain-view/reducers/tooltip.js 4 0.0%
src/chainstrap/actions/index.js 4 0.0%
src/chainstrap/chain-view/components/explore-in-etherscan/index.js 5 0.0%
src/chainstrap/chain-view/index.js 5 0.0%
Totals Coverage Status
Change from base Build 503: -9.3%
Covered Lines: 173
Relevant Lines: 1062

💛 - Coveralls

@satello satello force-pushed the feat/display_evidence_from_standard branch from 36b64d1 to acdced3 Compare November 8, 2018 19:01
@satello satello force-pushed the feat/display_evidence_from_standard branch from acdced3 to cd562c8 Compare November 14, 2018 21:23
@satello satello merged commit ed3516d into develop Nov 15, 2018
@satello satello deleted the feat/display_evidence_from_standard branch November 15, 2018 06:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants