Skip to content

Feat: New landing page #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 17, 2023
Merged

Feat: New landing page #59

merged 15 commits into from
Jan 17, 2023
+1,431 −593

Conversation

@alcercu
Copy link
Contributor

@alcercu alcercu commented Sep 5, 2022

No description provided.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

gratestas
gratestas previously approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@gratestas gratestas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works fine:fire:. I have a couple of minor personal suggestions though :

  • In Translators component, It would be nice to add a bit of white space between the Title, separator, and text body. It feels like they are squeezed too much.

  • Also, the font size of sentences in Requesters and of the body text in CardContainer could be decreased a bit to facilitate a better balance with the rest elements.

Not required but I would do it.

jaybuidl
jaybuidl previously approved these changes Jan 16, 2023
View reviewed changes
@alcercu alcercu dismissed stale reviews from jaybuidl and gratestas via 96ffa14 January 17, 2023 09:27
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alcercu alcercu requested review from gratestas and jaybuidl January 17, 2023 11:44
@alcercu alcercu merged commit 6308cf6 into master Jan 17, 2023
@alcercu alcercu deleted the feat/landing-page branch January 17, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaybuidl jaybuidl Awaiting requested review from jaybuidl

1 more reviewer

@gratestas gratestas gratestas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alcercu alcercu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alcercu @jaybuidl @gratestas