Add OG preview and fix curl pipe execution#2
Conversation
BASH_SOURCE[0] is empty when piped, so the guard must also check for empty to support the curl | bash install pattern.
- Add OG and Twitter Card meta tags to index.html - Generate 1200x630 preview image with Klever branding - Include og-image.png in deploy workflow
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThe PR adds social media preview capabilities to the homepage with Open Graph and Twitter Card meta tags, includes copying an og-image asset during deployment, and updates the install script to support execution via piped curl commands in addition to direct script invocation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
There was a problem hiding this comment.
Pull request overview
This pull request fixes the curl | bash execution issue and adds social media preview functionality to the Klever installer landing page. The bash sourcing guard now correctly detects when the script is piped to bash (where BASH_SOURCE[0] is empty) and executes the main function in that scenario, while still preventing execution when the script is sourced for testing.
Changes:
- Fixed bash execution guard to handle empty
BASH_SOURCE[0]when piped via curl - Added Open Graph and Twitter Card meta tags for rich social media previews
- Included og-image.png in the GitHub Pages deployment workflow
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| install.sh | Updated bash guard to check for empty BASH_SOURCE[0] to support curl pipe execution |
| index.html | Added Open Graph and Twitter Card meta tags with proper image dimensions (1200x630) |
| .github/workflows/deploy.yml | Included og-image.png in the site files copied during deployment |
| og-image.png | Added 1200x630 branded preview image for social media sharing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
curl | bashexecution —BASH_SOURCE[0]is empty when piped, so the guard now also checks for empty to runmainog-image.png)og-image.pngin GitHub Pages deploy workflowTest plan
curl -fsSL https://install.klever.org/install.sh | bashruns the installersource ./install.shdoes NOT run main (sourcing guard still works)install.klever.orglink on Slack/Twitter and confirm preview rendersSummary by CodeRabbit
New Features
Chores